Closed Bug 4842 Opened 25 years ago Closed 25 years ago

Private NSPR headers should not be exported to mozilla/dist

Categories

(NSPR :: NSPR, defect, P3)

Product:
NSPR
Component:
NSPR
Platform:
All
Windows NT
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: wtc, Assigned: wtc)

Details

Right now we still export private NSPR headers such
as primpl.h and md/_xxxos.h to mozilla/dist.  This
means other Mozilla modules can still include our
private headers.  We should not export our private
headers to mozilla/dist.

Note: three private headers (pprio.h, pprthred.h,
and prpriv.h) still need to be exported to mozilla/dist
because we allow certain applications to include
these three private headers.
Status: NEW → ASSIGNED
Accepted the bug.
NSPR now has its own Bugzilla product.  Moving this bug to the NSPR product.
Need to wait on the fix of Bugzilla bug #7551.
I verified that the inclusion of private NSPR headers
in Bugzilla bug #7551 is not being activated because
the makefile statements to add -DNO_NETWORK_POLLING to
the compiler command line are commented out in:
mozilla/network/main/makefile.win, revision 1.37
mozilla/network/module/makefile.win, revision 1.41

So I went ahead and checked in my changes.  Now
private/pprmwait.h, private/primpl.h, and md/*.h
are not exported to mozilla/dist.  NSPR files get
these private header files from the source tree.

Modified files:
mozilla/nsprpub/lib/ds/Makefile
mozilla/nsprpub/lib/prstreams/Makefile
mozilla/nsprpub/pr/include/Makefile
mozilla/nsprpub/pr/include/md/Makefile
mozilla/nsprpub/pr/include/obsolete/Makefile
mozilla/nsprpub/pr/include/private/Makefile
mozilla/nsprpub/pr/src/bthreads/Makefile
mozilla/nsprpub/pr/src/cplus/Makefile
mozilla/nsprpub/pr/src/io/Makefile
mozilla/nsprpub/pr/src/linking/Makefile
mozilla/nsprpub/pr/src/malloc/Makefile
mozilla/nsprpub/pr/src/md/Makefile
mozilla/nsprpub/pr/src/md/beos/Makefile
mozilla/nsprpub/pr/src/md/os2/Makefile
mozilla/nsprpub/pr/src/md/unix/Makefile
mozilla/nsprpub/pr/src/md/windows/Makefile
mozilla/nsprpub/pr/src/memory/Makefile
mozilla/nsprpub/pr/src/misc/Makefile
mozilla/nsprpub/pr/src/pthreads/Makefile
mozilla/nsprpub/pr/src/threads/Makefile
mozilla/nsprpub/pr/src/threads/combined/Makefile
mozilla/nsprpub/pr/tests/Makefile
mozilla/nsprpub/pr/tests/selct_nm.c
mozilla/nsprpub/pr/tests/selct_to.c
mozilla/nsprpub/pr/tests/w16gui/Makefile
mozilla/nsprpub/tools/Makefile
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Mixed one file in the previous checkin:
mozilla/nsprpub/makefile.win

Also checked in the fix to the internal
cvs repository (/m/src):
ns/nspr20/makefile.win
ns/nspr20/lib/ds/Makefile
ns/nspr20/lib/prstreams/Makefile
ns/nspr20/pr/include/Makefile
ns/nspr20/pr/include/md/Makefile
ns/nspr20/pr/include/obsolete/Makefile
ns/nspr20/pr/include/private/Makefile
ns/nspr20/pr/src/bthreads/Makefile
ns/nspr20/pr/src/cplus/Makefile
ns/nspr20/pr/src/io/Makefile
ns/nspr20/pr/src/linking/Makefile
ns/nspr20/pr/src/malloc/Makefile
ns/nspr20/pr/src/md/Makefile
ns/nspr20/pr/src/md/beos/Makefile
ns/nspr20/pr/src/md/os2/Makefile
ns/nspr20/pr/src/md/unix/Makefile
ns/nspr20/pr/src/md/windows/Makefile
ns/nspr20/pr/src/memory/Makefile
ns/nspr20/pr/src/misc/Makefile
ns/nspr20/pr/src/pthreads/Makefile
ns/nspr20/pr/src/threads/Makefile
ns/nspr20/pr/src/threads/combined/Makefile
ns/nspr20/pr/tests/Makefile
ns/nspr20/pr/tests/selct_nm.c
ns/nspr20/pr/tests/selct_to.c
ns/nspr20/pr/tests/w16gui/Makefile
ns/nspr20/tools/Makefile

Marked the bug fixed.  To verify,
cd into mozilla/dist/<platform.OBJ>/include
and make sure that there is not a 'md'
subdirectory and no pprmwait.h and primpl.h
under the 'private' subdirectory.
Status: RESOLVED → VERIFIED
verified with pull from jun 08, 1999
Target Milestone: M7 → ---
You need to log in before you can comment on or make changes to this bug.