484220 - pointless file move in search service

Status: RESOLVED WONTFIX

(Firefox :: Search, defect)

Description

[Mike Connor [:mconnor]]

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/search/nsSearchService.js#2853

Should just be a remove, since the _serializeToFile() piece is going to overwrite the file anyway, so we're just burning cycles.

Comment 1

[Andre Klapper]

As line numbers change over the years: Mike, is this still an issue?
If so, can you paste the corresponding code line here please?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Yes, this is still a problem. Hg lets you see files from the past, the link in question is:

http://hg.mozilla.org/mozilla-central/annotate/198155c14694/toolkit/components/search/nsSearchService.js#l2853

which still exists on trunk.

Comment 3

[Florian Quèze [:florian]]

We should remove this code (bug 862137), not fix it.