484272 - Breakdown details for the Firebug stats dashboard do not work

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Statistics, defect, P3)

Description

[Daniel Einspanjer [:dre] [:deinspanjer]]

When you hit the page, you see the summary trend lines, but if you try to change to Add-on Versions or Applications, etc, it does not display the collection of filters at the top.
The following error is logged in the error console:

Error: plotSelection.summary.updatepings is undefined
Source File: https://addons.mozilla.org/js/stats/plots.js
Line: 265

Oddly, two other dashboards I tried work fine (Lightning and Spectator)

Comment 2

[John J. Barton]

Is this bug visible to the folks who can fix it? We are about to release Firebug 1.4.0 and we'd like to have data on adoption.

Comment 3

[Rob Campbell [:rc] (:robcee)]

yeah, this has been killing us during the beta cycle. Need better data!

john, this should be visible and in the house of the people who can fix this.

Comment 4

[Wil Clouser [:clouserw]]

we'll look at it in the next cycle

Comment 5

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 1

Meh, broken JSON. JSONlint.com does still not consider the stats dashboard's JSON valid, but it should be parsed right now. Actually making all of that JSON *valid* is another bug (for instance, trailing commas in objects are invalid in JS).

Comment 6

[Daniel Einspanjer [:dre] [:deinspanjer]]

Is any of that JSON the data that we serialize and upload into the update_counts table? Or is it intermediate data built by the AMO webserver?

Comment 7

[Fred Wenzel [:wenzel]]

The data in the DB was not invalid (or rather, it was, but that's not your fault). It is not escaped properly on our end, rendering an invalid JSON response though.

Comment 8

[Fred Wenzel [:wenzel]]

Escaping issue. Hiding from too curious eyes for now.

Comment 9

[Wil Clouser [:clouserw]]

Comment on attachment 389564 [details] [diff] [review]
Patch, rev. 1

Thanks Fred!  good catch

Comment 10

[Fred Wenzel [:wenzel]]

r30102.

Comment 11

[John J. Barton]

I am wondering what it means that this bug is marked FIXED? The dashboard still does not work.

Comment 12

[Wil Clouser [:clouserw]]

(In reply to comment #11)
> I am wondering what it means that this bug is marked FIXED? The dashboard still
> does not work.

It's fixed on https://preview.addons.mozilla.org/en-US/firefox/statistics/addon/1843 which mirrors the trunk of our repository.  The fix will be pushed live at our next scheduled push (currently targeting next wednesday).

Comment 13

[John J. Barton]

You might like to look at the page you posted before you push the fix.

Comment 14

[Wil Clouser [:clouserw]]

(In reply to comment #13)
> You might like to look at the page you posted before you push the fix.

I've seen it and am prepared to push the fix.

Comment 15

[Dave Garrett]

(In reply to comment #13)
> You might like to look at the page you posted before you push the fix.

If you're saying that the page isn't right, then I should point out that preview doesn't get stats. (no one is downloading or updating from preview) Thus the summary view is empty and the other graphs drop off a cliff after the most recent dump from production mid last month. Makes testing fixes like this harder.

Comment 16

[John J. Barton]

(In reply to comment #14)
> I've seen it and am prepared to push the fix.

When?

Comment 17

[Stephen Donner [:stephend] Not actively reading bugmail]

We've already shipped 5.0.8; this should be fixed on https://addons.mozilla.org/en-US/firefox/statistics/addon/1843.  Reopen if not, thanks.

Comment 18

[Fred Wenzel [:wenzel]]

Since this has shipped, it's not confidential anymore.