Closed
Bug 484291
Opened 15 years ago
Closed 15 years ago
INS_CONSTPTR should not cast to void*
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: Waldo, Assigned: Waldo)
Details
(Keywords: fixed1.9.1, Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
3.10 KB,
patch
|
gal
:
review+
|
Details | Diff | Splinter Review |
It inserts a pointer; if you want to insert a number cast to a pointer, make it explicit so it's clearer what's being done.
Attachment #368370 -
Flags: review?(gal)
Updated•15 years ago
|
Attachment #368370 -
Attachment is patch: true
Attachment #368370 -
Attachment mime type: application/octet-stream → text/plain
Updated•15 years ago
|
Attachment #368370 -
Flags: review?(gal) → review+
Assignee | ||
Comment 1•15 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/5f40ac8ed7d4
Whiteboard: fixed-in-tracemonkey
Comment 2•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/5f40ac8ed7d4
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•15 years ago
|
Flags: in-testsuite-
Comment 3•15 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/557c718cd288
Flags: wanted1.9.1+
Keywords: fixed1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•