nsCharsetMenu violates XPCOM calling conventions

RESOLVED FIXED

Status

()

Core
Internationalization
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
nsCharsetMenu::GetURI calls PL_strdup, but it should use the XPCOM allocator.
(Assignee)

Comment 1

9 years ago
Created attachment 368405 [details] [diff] [review]
Proposed patch
Assignee: smontagu → neil
Status: NEW → ASSIGNED
Attachment #368405 - Flags: superreview?(jag)
Attachment #368405 - Flags: review?(smontagu)

Comment 2

9 years ago
Comment on attachment 368405 [details] [diff] [review]
Proposed patch

I would suggest we change nsCRT::strdup(const char*) to use the same allocator as nsCRT::strdup(const PRUnichar*), but that's gonna affect a lot more people. New bug?
Attachment #368405 - Flags: superreview?(jag) → superreview+
Comment on attachment 368405 [details] [diff] [review]
Proposed patch

If only he was an intl peer, it would have been more appropriate to get Uri to review this...
Attachment #368405 - Flags: review?(smontagu) → review+
(Assignee)

Comment 4

9 years ago
Pushed changeset e1120120b1b7 to mozilla-central.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.