pymake should support -k (--keep-going)

RESOLVED FIXED

Status

RESOLVED FIXED
10 years ago
8 months ago

People

(Reporter: Swatinem, Assigned: Swatinem)

Tracking

Trunk
x86
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
From gnu makes manpage:
       -k, --keep-going
            Continue  as  much  as  possible after an error.  While the target
            that failed, and those that depend on it, cannot  be  remade,  the
            other dependencies of these targets can be processed all the same.

pymake currently fails when passing -k:

make.py: error: no such option: -k

It should either start to support this flag or just ignore it instead of failing.
(Assignee)

Comment 1

10 years ago
I have a clone of pymake here: http://hg.swatinem.de/pymake/
currently adds support for #T grep-for: "text" and adds a test for -k behavior.
I'm still trying to understand how pymake actually works and I may make -k work sometime.
(Assignee)

Comment 2

10 years ago
Created attachment 368669 [details] [diff] [review]
support for -k and #T grep-for

This patch includes changes to runtests to support #T grep-for: syntax, a test for keep-going behavior and the implementation for --keep-going.

I wonder if there is any easier way to pass that flag on as to create a new Makefile member variable.

Comments much appreciated.
Assignee: nobody → arpad.borsos
Status: NEW → ASSIGNED
Attachment #368669 - Flags: review?(benjamin)

Comment 3

10 years ago
http://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/rev/50d8e87e8af3

Intermediate changes totally hosed your patch, plus there were details being missed in the parallel case. I think both of those have been resolved in my rework.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Updated

10 years ago
Attachment #368669 - Flags: review?(benjamin)

Updated

8 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.