Closed
Bug 484574
Opened 17 years ago
Closed 17 years ago
tools.sh using command separators inside test delimiters
Categories
(NSS :: Test, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
3.12.3
People
(Reporter: nelson, Assigned: nelson)
Details
Attachments
(1 file)
|
2.69 KB,
patch
|
slavomir.katuscak+mozilla
:
review+
|
Details | Diff | Splinter Review |
The checkin for Bug 452076 broke the script for MKS shell users.
It caused the test command to return unintended results by putting a
command separator inside the test arguments.
This patch fixes it by changing && to -a inside the test delimiters [ and ].
This patch also changes the string used to request default test settings from
the empty string "" to "DEFAULT". This change is merely a debugging aid, and
also makes the string self documenting.
Slavo, please review.
Attachment #368699 -
Flags: review?(slavomir.katuscak)
|
||
Updated•17 years ago
|
Attachment #368699 -
Flags: review?(slavomir.katuscak) → review+
|
Assignee | |
Comment 1•17 years ago
|
||
Thanks for the quick review, Slavo.
Checking in tools.sh; new revision: 1.19; previous revision: 1.18
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 2•17 years ago
|
||
By the way, && also works between test delimiters when quoted.
That is, '&&' works fine between [ and ] even though unquoted does not.
You need to log in
before you can comment on or make changes to this bug.
Description
•