484577 - Browser crash when CMD+Q+W hit

Status: RESOLVED WORKSFORME

(Firefox :: General, defect)

Description

[Zachary Graham]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3) Gecko/20090305 Firefox/3.1b3
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3) Gecko/20090305 Firefox/3.1b3

The browser will crash (and crash reporter will open) If you hit W+Q at the same time when trying to CMD+W or CMD+Q

Reproducible: Always

Steps to Reproduce:
1. Open Browser
2. Hit CMD+Q+W
3. ???
4. Profit

Q and W must be pressed at the same time. If either one is noticeably first, crash does not occur.

Actual Results:  
Browser quits and a crash reporter dialog box opens

Expected Results:  
Handled the accidental Q+W press gracefully  (quit or close the current tab, it's up to you guys)

Since q and w are next to each other, it is possible for people to press both CMD+Q+W (or C-Q-W) on accident.

Comment 1

[Tyler Downer [He/Him]]

Can you try in safe mode or a new profile, and give a stacktrace? go to about:crashes and give the one from the time your crash happened.

Comment 2

[Jesse Ruderman]

I tried this a few times, and one of the times I got

2009-08-19 22:05:07.714 firefox-bin[1836:10b] *** Assertion failure in -[GeckoNSMenu itemAtIndex:], /SourceCache/AppKit/AppKit-949.54/Menus.subproj/NSMenu.m:819
2009-08-19 22:05:07.715 firefox-bin[1836:10b] Mozilla has caught an Obj-C exception [NSInternalInconsistencyException: Invalid parameter not satisfying: (index >= 0) && (index < (_itemArray ? CFArrayGetCount((CFArrayRef)_itemArray) : 0))]
2009-08-19 22:05:07.716 firefox-bin[1836:10b] Generating stack trace for Obj-C exception...
2009-08-19 22:05:09.329 firefox-bin[1836:10b] Stack trace:
Looking up symbols in process 1836 named:  firefox-bin
__raiseError (in CoreFoundation) + 331
objc_exception_throw (in libobjc.A.dylib) + 40
+[NSException raise:format:arguments:] (in CoreFoundation) + 155
-[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] (in Foundation) + 116
-[NSMenu itemAtIndex:] (in AppKit) + 219
-[NSMenu performKeyEquivalent:] (in AppKit) + 322
-[GeckoNSMenu performKeyEquivalent:] (in libwidget_mac.dylib) (nsMenuBarX.mm:830)
-[NSApplication _handleKeyEquivalent:] (in AppKit) + 492
-[NSApplication sendEvent:] (in AppKit) + 3997
-[NSApplication run] (in AppKit) + 867
nsAppShell::Run() (in libwidget_mac.dylib) (nsAppShell.mm:766)
nsAppStartup::Run() (in libtoolkitcomps.dylib) (nsAppStartup.cpp:193)
XRE_main (in XUL) (nsAppRunner.cpp:3394)
main (in firefox-bin) (nsBrowserApp.cpp:156)

but no crash

Comment 3

[Jesse Ruderman]

I even tried under valgrind (to slow Firefox way down, effectively making the Q and W presses even closer, and make certain random-crashes more visible) and didn't get anything.

Comment 4

[Jesse Ruderman]

(I was testing with a 32-bit Firefox trunk debug build on Mac OS X 10.5.x.)

Zachary, please reopen if you're still seeing this with a newer Firefox trunk build.