Closed Bug 484717 Opened 15 years ago Closed 15 years ago

Assert that our lock is held when the precondition says it should be

Categories

(Toolkit :: Storage, defect)

Product:
Toolkit
Component:
Storage
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.2a1

People

(Reporter: sdwilsh, Assigned: sdwilsh)

References

Details

Attachments

(1 file)

v1.0
545 bytes, patch
asuth
: review+
Details | Diff | Splinter Review 
NSPR has a nice new functionality that means we can assert our lock is held like we'd expect it to be.  Let's add that assertion!

AsyncExecuteStatements::BuildAndNotifyResults is currently the only function that qualifies for this.

Sadly, we cannot assert that the lock is not held, which is far more common in our code...
Whiteboard: [good first bug]
Attached patch v1.0 — — Splinter Review 
Assignee: nobody → sdwilsh
Status: NEW → ASSIGNED

        Attachment #369292 -
        Flags: review?(bugmail)

    
  
Whiteboard: [good first bug] → [needs review asuth]

        Attachment #369292 -
        Flags: review?(bugmail) → review+

    
  
Whiteboard: [needs review asuth] → [can land]

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/a70fcb2de049
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED
Whiteboard: [can land]
Target Milestone: --- → mozilla1.9.2a1

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: