Closed Bug 484861 Opened 15 years ago Closed 15 years ago

removal of JSObjectOps.set(Parent|Proto)

Categories

(Core :: JavaScript Engine, enhancement)

Product:
Core
Component:
JavaScript Engine
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: igor, Assigned: igor)

References

Details

(Keywords: fixed1.9.1, Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file, 2 obsolete files)

v3
9.86 KB, patch
igor
: review+
Details | Diff | Splinter Review 
Currently the only users of JSObjectOps.set(Parent|Proto) is the debug-only code in JS_Set(Parent|Proto). With the bug 437325 fixed that would be removed. Thus I suggest to remove these 2 fields from JSObjectOps.
Attached patch v1 (obsolete) — — Splinter Review 
The patch is straightforward removal of setParent, setProto and xdrObject (one more deadwood) from JSObjectOps.
Attachment #369263 - Flags: review?(mrbkap)
Attached patch v2 (obsolete) — — Splinter Review 
The previous patch is incomplete incomplete.
Attachment #369263 - Attachment is obsolete: true
Attachment #369264 - Flags: review?(mrbkap)
Attachment #369263 - Flags: review?(mrbkap)
Attachment #369264 - Flags: review?(mrbkap) → review+
Attached patch v3 — — Splinter Review 
The previous version of the patch required a trivial merge due to changes from the bug 483473.
Attachment #369264 - Attachment is obsolete: true
Attachment #370384 - Flags: review+
landed to TM - http://hg.mozilla.org/tracemonkey/rev/e824252798be

I nominate the bug for 1.9.1 to avoid having deadwood on the branch.
Flags: wanted1.9.1?
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/e824252798be
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: wanted1.9.1? → wanted1.9.1+
Resolution: --- → FIXED
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: