Closed Bug 484874 Opened 15 years ago Closed 15 years ago

Avoid passing nsIParser parameters to nsIDTD methods

Categories

(Core :: DOM: HTML Parser, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 484121

People

(Reporter: mozilla+ben, Assigned: mozilla+ben)

References

Details

Attachments

(1 file, 1 obsolete file)

The only parser properties that our DTDs care about (interruptibility, document.write status, document charset) remain constant throughout the model-building process.  If we can avoid passing the parser to the DTD, it will be easier to parallelize the DTD's operation relative to the parser, and we'll have one fewer risk for reference-counting cycles.
Depends on: 484121
I'll create a separate bug to get rid of the unused {START,STOP}_TIMER macros.
Attachment #368995 - Flags: review?(mrbkap)
Blocks: 484898
Asserting the truth of aCanInterrupt in CViewSourceHTML::BuildModel, since the view source DTD doesn't run scripts and therefore can't execute document.write.

Fixing some parameter names in nsIDTD.

Amending a comment that referred to the now-nonexistent mParser->CanInterrupt() call in CNavDTD::BuildModel.
Attachment #368995 - Attachment is obsolete: true
Attachment #368999 - Flags: review?(mrbkap)
Attachment #368995 - Flags: review?(mrbkap)
Attachment #368999 - Flags: superreview+
Attachment #368999 - Flags: review?(mrbkap)
Attachment #368999 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/c0fad0d1535d
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
backed out: http://hg.mozilla.org/mozilla-central/rev/732ee74b2e5d

mrbkap's theory is that the crash was due to inconsistent use of nsresult/NS_IMETHODIMP (for CNavDTD::HandleToken, e.g.).  Will clean up tomorrow.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
The motivation for this bug was addressed in bug 484121, by patch 6 of 6.
Status: REOPENED → RESOLVED
Closed: 15 years ago15 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: