Closed
Bug 484874
Opened 15 years ago
Closed 15 years ago
Avoid passing nsIParser parameters to nsIDTD methods
Categories
(Core :: DOM: HTML Parser, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 484121
People
(Reporter: mozilla+ben, Assigned: mozilla+ben)
References
Details
Attachments
(1 file, 1 obsolete file)
36.22 KB,
patch
|
mrbkap
:
review+
mrbkap
:
superreview+
|
Details | Diff | Splinter Review |
The only parser properties that our DTDs care about (interruptibility, document.write status, document charset) remain constant throughout the model-building process. If we can avoid passing the parser to the DTD, it will be easier to parallelize the DTD's operation relative to the parser, and we'll have one fewer risk for reference-counting cycles.
Assignee | ||
Comment 1•15 years ago
|
||
I'll create a separate bug to get rid of the unused {START,STOP}_TIMER macros.
Attachment #368995 -
Flags: review?(mrbkap)
Assignee | ||
Comment 2•15 years ago
|
||
Asserting the truth of aCanInterrupt in CViewSourceHTML::BuildModel, since the view source DTD doesn't run scripts and therefore can't execute document.write. Fixing some parameter names in nsIDTD. Amending a comment that referred to the now-nonexistent mParser->CanInterrupt() call in CNavDTD::BuildModel.
Attachment #368995 -
Attachment is obsolete: true
Attachment #368999 -
Flags: review?(mrbkap)
Attachment #368995 -
Flags: review?(mrbkap)
Updated•15 years ago
|
Attachment #368999 -
Flags: superreview+
Attachment #368999 -
Flags: review?(mrbkap)
Attachment #368999 -
Flags: review+
Assignee | ||
Comment 3•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/c0fad0d1535d
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•15 years ago
|
||
backed out: http://hg.mozilla.org/mozilla-central/rev/732ee74b2e5d mrbkap's theory is that the crash was due to inconsistent use of nsresult/NS_IMETHODIMP (for CNavDTD::HandleToken, e.g.). Will clean up tomorrow.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 5•15 years ago
|
||
The motivation for this bug was addressed in bug 484121, by patch 6 of 6.
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•