Closed Bug 484878 Opened 17 years ago Closed 17 years ago

Add application_id to collections

Categories

(addons.mozilla.org Graveyard :: Collections, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: fligtar, Assigned: wenzel)

References

Details

Attachments

(2 files, 1 obsolete file)

Collections should be associated with a particular application, e.g., a Firefox collection or Thunderbird collection. Add-ons in the collection might support multiple apps, but an add-on shouldn't be in a collection if it *doesn't* support that application. On the website when making a collection, the app will default to whatever app the user's currently browsing the AMO site in, and can be changed from the manage collections page. From the API, the application should always be Firefox.
Priority: -- → P1
Assignee: nobody → fwenzel
Blocks: 456132
Attached patch Patch, rev. 1Splinter Review
Saves the application ID when creating a new one. Adds the app id to the API's XML results (tests updated, too). Note: When creating a collection from the API, it is possible to choose the app, though it *defaults* to Firefox.
Attachment #372867 - Flags: review?(lorchard)
Status: NEW → ASSIGNED
Comment on attachment 372867 [details] [diff] [review] Patch, rev. 1 One issue in the remora.sql: CONSTRAINT `collections_ibfk_1` FOREIGN KEY (`application_id`) REFERENCES `remora_prod`.`applications` (`id`) Once I removed the "`remora_prod`." in the REFERENCES, all the tests passed and things look good - r+ with that caveat.
Attachment #372867 - Flags: review?(lorchard) → review+
Thanks, I missed that.
Attached file Fixed SQL
Attachment #372866 - Attachment is obsolete: true
Thanks, I committed this to r24446 and added the SQL to be ran to the wiki page.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: