Closed
Bug 484878
Opened 17 years ago
Closed 17 years ago
Add application_id to collections
Categories
(addons.mozilla.org Graveyard :: Collections, defect, P1)
addons.mozilla.org Graveyard
Collections
Tracking
(Not tracked)
RESOLVED
FIXED
BW-M4
People
(Reporter: fligtar, Assigned: wenzel)
References
Details
Attachments
(2 files, 1 obsolete file)
|
8.29 KB,
patch
|
lorchard
:
review+
|
Details | Diff | Splinter Review |
|
222 bytes,
text/plain
|
Details |
Collections should be associated with a particular application, e.g., a Firefox collection or Thunderbird collection. Add-ons in the collection might support multiple apps, but an add-on shouldn't be in a collection if it *doesn't* support that application.
On the website when making a collection, the app will default to whatever app the user's currently browsing the AMO site in, and can be changed from the manage collections page. From the API, the application should always be Firefox.
| Reporter | ||
Updated•17 years ago
|
Priority: -- → P1
Updated•17 years ago
|
Assignee: nobody → fwenzel
| Assignee | ||
Comment 1•17 years ago
|
||
| Assignee | ||
Comment 2•17 years ago
|
||
Saves the application ID when creating a new one. Adds the app id to the API's XML results (tests updated, too).
Note: When creating a collection from the API, it is possible to choose the app, though it *defaults* to Firefox.
Attachment #372867 -
Flags: review?(lorchard)
| Assignee | ||
Updated•17 years ago
|
Status: NEW → ASSIGNED
Comment 3•17 years ago
|
||
Comment on attachment 372867 [details] [diff] [review]
Patch, rev. 1
One issue in the remora.sql:
CONSTRAINT `collections_ibfk_1` FOREIGN KEY (`application_id`) REFERENCES `remora_prod`.`applications` (`id`)
Once I removed the "`remora_prod`." in the REFERENCES, all the tests passed and things look good - r+ with that caveat.
Attachment #372867 -
Flags: review?(lorchard) → review+
| Assignee | ||
Comment 4•17 years ago
|
||
Thanks, I missed that.
| Assignee | ||
Comment 5•17 years ago
|
||
Attachment #372866 -
Attachment is obsolete: true
| Assignee | ||
Comment 6•17 years ago
|
||
Thanks, I committed this to r24446 and added the SQL to be ran to the wiki page.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•