484943 - init.sh is not MP safe

Status: NEW

(NSS :: Test, defect, P5)

Description

[Julien Pierre]

On my AMD Vista x64 quad core box, I ran the following script called qa4.bat :

@echo off

set PORT=1000
set USE_64=
set BUILD_OPT=
start "3.11 QA 32 DBG" qa.bat

set PORT=1001
set USE_64=
set BUILD_OPT=1
start "3.11 QA 32 OPT" qa.bat

set PORT=1002
set USE_64=1
set BUILD_OPT=
start "3.11 QA 64 DBG" qa.bat

set PORT=1003
set USE_64=1
set BUILD_OPT=1
start "3.11 QA 64 OPT" qa.bat

qa.bat is :

@echo off
cd mozilla\security\nss\tests
set HOST=localhost
set DOMSUF=localdomain
sh all.sh
cd ..\..\..\..

Unfortunately, 3 of the 4 concurrent QA runs ended up running in the same directory, localhost.5 ! This caused major problems, and the tests hung when waiting for password files eventually.

The same problem happened on the trunk too.

The problem is in init.sh . It creates the hostdir with mkdir -p, which ignores errors if the host directory already exists. init.sh needs to detect this case and try to increment the number to make a new directory if it already exists.

Comment 1

[Julien Pierre]

Note that since several test runs ended up sharing the same host directory, a lot of other unpredictable behavior occurred. Things like the output of multiple results.html being intermixed. sigh.