485073 - OS/2 enable test plugin equivalent to other platforms

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Walter Meinl]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9.2a1pre) Gecko/20090323 Minefield/3.6a1pre
Build Identifier: 

I thought a while ago that we should use an equivalent test plugin like the other platforms. But getting the old one in bug471759 back to build properly. However, bug484137 removed the modules/plugin/tools directory, where we were the only left over consumer. So, now, it's time to get the new test plugin. I have already a patch more or less ready, but will attach it after checking it again.

Reproducible: Always

Comment 1

[Walter Meinl]

Attachment: add a new test plugin [Checkin: Comment 3]

The code for the test plugin itself (nptest_os2.cpp) was copied from nptest_gtk2.cpp. It's a stub, but it compiles and builds a nptest.dll. Basically the bug here does the same as was done for the qt-build in bug474421

Comment 2

[Peter Weilbacher]

Comment on attachment 369229 [details] [diff] [review]
add a new test plugin
[Checkin: Comment 3]

Great!. As this doesn't touch other code other than trivially changing #ifdefs, I think my review should be enough.

Comment 3

[Serge Gautherie (:sgautherie)]

Comment on attachment 369229 [details] [diff] [review]
add a new test plugin
[Checkin: Comment 3]


http://hg.mozilla.org/mozilla-central/rev/0da5126a17d3

Comment 4

[Walter Meinl]

Peter, I think we should take this also for 1.9.1, though the old plugin tester won't be removed there. But since the old tools tester dirs are declared to be unmaintained, we'd stay otherwise the only consumers for the old tests.

Comment 5

[Walter Meinl]

Ah, I forgot, on 1.9.1 branch there is still a generic new test plugin. It builds out of the box, requires only the Makefile changes to point to it.

Comment 6

[Walter Meinl]

Attachment: build the common test plugin on OS/2 also on branch [Checkin: Comment 8]

Comment 7

[Walter Meinl]

(In reply to comment #6)
> Created an attachment (id=374332) [details]
> build the common test plugin on OS/2 also on branch
Ups, lost from the radar

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 374332 [details] [diff] [review]
build the common test plugin on OS/2 also on branch
[Checkin: Comment 8]


http://hg.mozilla.org/releases/mozilla-1.9.1/rev/5cd96b6afea3