485235 - Remove the mac-specific wizard-label-box in wizard.xml

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Stefan [:stefanh]]

We haven't shown the the value of the pagestep attribute (in a mac wizard page) since late 2004. I think it's time to remove it for real - it seems kind of pointless to have a mac-specific wizard-label-box when all we do with it is hiding it in wizard.css.

Comment 1

[Stefan [:stefanh]]

Attachment: Remove wizard-label-box

Shouldn't affect any consumer of pinstripe's wizard.css.

Comment 2

[Dão Gottwald [:dao]]

This makes the pagestep attribute unused. Remove it? The pageStep property is unused, too.
See http://mxr.mozilla.org/comm-central/search?string=pagestep

Comment 3

[Stefan [:stefanh]]

(In reply to comment #2)
> This makes the pagestep attribute unused. Remove it? The pageStep property is
> unused, too.

I wonder if it's ok to do it at this stage (since I would like to have this on 191).

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 369366 [details] [diff] [review]
Remove wizard-label-box

This looks fine. pagestep can be handled in a followup (it's not clear to me that it's unused).

Comment 5

[Stefan [:stefanh]]

http://hg.mozilla.org/mozilla-central/rev/f2b4ce52e2e7

Comment 6

[Stefan [:stefanh]]

Comment on attachment 369366 [details] [diff] [review]
Remove wizard-label-box

This removes an element that atm is hidden with display: none in pinstripe.       Cross-platform theme devs should be happy with this. No real impact on Firefox, since the element hasn't been visible since 2004.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 369366 [details] [diff] [review]
Remove wizard-label-box

a191=beltzner

Comment 8

[Stefan [:stefanh]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/d5c4ccd85560