485269 - add head.js and cleanup functions to browser chrome tests

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[David Dahl :ddahl]

It would be nice to have a module or head.js for browser chrome testing, for instance all places tests would want to call this function on end:


var hs = Cc["@mozilla.org/browser/nav-history-service;1"].
         getService(Ci.nsINavHistoryService);
var mDBConn = hs.QueryInterface(Ci.nsPIPlacesDatabase).DBConnection;

function cleanDatabase() {
   mDBConn.executeSimpleSQL("DELETE FROM moz_places");
   mDBConn.executeSimpleSQL("DELETE FROM moz_historyvisits");
   mDBConn.executeSimpleSQL("DELETE FROM moz_anno_attributes");
   mDBConn.executeSimpleSQL("DELETE FROM moz_annos");
   mDBConn.executeSimpleSQL("DELETE FROM moz_items_annos");
   mDBConn.executeSimpleSQL("DELETE FROM moz_inputhistory");
   mDBConn.executeSimpleSQL("DELETE FROM moz_keywords");
   mDBConn.executeSimpleSQL("DELETE FROM moz_favicons");
  var sql = "DELETE FROM moz_bookmarks WHERE id NOT IN (SELECT folder_id from moz_bookmarks_roots)";
   mDBConn.executeSimpleSQL(sql);
}

Comment 1

[Marco Bonardo [:mak]]

i hope to have some time to take a look at this, no promises though.

Comment 2

[Marco Bonardo [:mak]]

Attachment: patch v1.0

i thought this was harder, looks like just so easy.

Comment 3

[Marco Bonardo [:mak]]

Attachment: patch v1.1

forgot auto-test files.

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 412395 [details] [diff] [review]
patch v1.1

gavin, feedback about this?

Comment 5

[Marco Bonardo [:mak]]

Attachment: patch v1.2

applies on top of bug 528469 (by using this._scriptLoader).

Adds head.js, and support for registerCleanupFunction(aFunction), that is a similar functionality to what we have in xpcshell tests, you can register one or more functions that will be run after the test finishes, and before starting next test.

Comment 6

[Marco Bonardo [:mak]]

pushed to the tryserver and got green

Comment 7

[Marco Bonardo [:mak]]

Attachment: patch v1.3

unbitrot against new patch in bug 528469

Comment 8

[Marco Bonardo [:mak]]

my push of all the three patches about b-c tests has gone green.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 421859 [details] [diff] [review]
patch v1.3

>diff --git a/testing/mochitest/browser-test.js b/testing/mochitest/browser-test.js

>   realNextTest: function Test_realNextTest() {
>+    if (this.currentTest) {
>+      // Run registered cleanup functions for the previous test.

"Run cleanup functions for the current test before moving on to the next".

I think this code should go into nextTest() before the call to waitForWindowState, though, since the cleanup functions could potentially be used to clean up windows, right?

>diff --git a/testing/mochitest/tests/browser/Makefile.in b/testing/mochitest/tests/browser/Makefile.in

>-_BROWSER_TEST_FILES = 	  browser_pass.js \
>+_BROWSER_TEST_FILES = \
>+                    head.js \
>+                    browser_head.js \
>+                    browser_pass.js \
> 	                  browser_async.js \

fix the indent here?

r=me with those addressed. Should probably add some documentation to this on the MDC page: https://developer.mozilla.org/En/Browser_chrome_tests

Comment 10

[Marco Bonardo [:mak]]

Attachment: patch v1.4

Addressed comments.

Yes makes MUCH sense running cleanup functions before checking windows status.

Comment 11

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/cd5868a825d8

Comment 12

[Marco Bonardo [:mak]]

updated https://developer.mozilla.org/en/Browser_chrome_tests