Closed
Bug 485325
Opened 16 years ago
Closed 16 years ago
nsLocalFileUnix::IsSymlink() should check result of lstat()
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jag+mozilla, Assigned: jag+mozilla)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
630 bytes,
patch
|
jaas
:
review+
benjamin
:
superreview+
|
Details | Diff | Splinter Review |
If you call IsSymlink() when there's no file (or any other reason why lstat() would return -1) the value of st_mode is undefined, so _retval is randomly true or false, and there's no indication anything was wrong.
|
Assignee | |
Comment 1•16 years ago
|
||
Assignee: nobody → jag
Attachment #369465 -
Flags: superreview?(benjamin)
Attachment #369465 -
Flags: review?(joshmoz)
Attachment #369465 -
Flags: review?(joshmoz) → review+
|
||
Updated•16 years ago
|
Attachment #369465 -
Flags: superreview?(benjamin) → superreview+
|
|
Assignee | |
Comment 2•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•