485326 - "Table of contents" showing in new search results

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect)

Description

[David Tenser [:djst]]

In some search results (see URL), the string "Table Of Contents" is showing up in the search result summary. The summary should always end before the TOC marker, since our article summary is always placed before it.

Comment 1

[Paul Craciunoiu [:paulc]]

Attachment: Proposed fix with strpos

Needs testing. My machine keeps timing out when indexing, but I managed to test a bit.

Comment 2

[Laura Thomson :laura]

Comment on attachment 369628 [details] [diff] [review]
Proposed fix with strpos

Is this a complete patch?  Where is $maketocpos set?

Comment 3

[Paul Craciunoiu [:paulc]]

Attachment: Proposed fix with strpos, v2

Oops! Of course... a minor detail :D

Comment 4

[Paul Craciunoiu [:paulc]]

Laura...?

Comment 5

[Paul Craciunoiu [:paulc]]

r24429 / r24430
Thanks Laura!

Comment 6

[E. Cooper [:ecooper]]

This breaks on http://support-stage.mozilla.org/ko/kb/%EB%8B%A4%EC%9A%B4%EB%A1%9C%EB%93%9C%20%EA%B4%80%EB%A6%AC%EC%9E%90 while indexing.

If '{maketoc}' occurs before any display text (text present after being parsed for wiki syntax) it will result in an essentially empty $document['data']. This will make searching the document useless, and cause problems when inserting words into the se_word table.

For such an example see: 

https://support-stage.mozilla.org/tiki-pagehistory.php?locale=ko&page=%EB%8B%A4%EC%9A%B4%EB%A1%9C%EB%93%9C+%EA%B4%80%EB%A6%AC%EC%9E%90&source=0

While this is different than the original request, can't we just use something like this?

$document['data'] = preg_replace('/\{maketoc\}/Ui', '', $document['data']);

It'll just remove the {maketoc} command and stop the toc from being created.

Comment 7

[Paul Craciunoiu [:paulc]]

Tested locally and seems better to follow Eric's suggestion. We should wait for the reindexing bug and do some testing to make sure this works as expected.
r24524-5 / r24526

Thanks Eric!

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Looking fixed on https://support-stage.mozilla.org/tiki-newsearch.php?where=d&locale=en-US&q=menu+reference&sa= to me; verified.

Will do more search testing, of course...