485451 - setting the *titlebarcolor attributes doesn't take effect immediately

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

When I set the activetitlebarcolor, inactivetitlebarcolor, and titlebarcolor attributes on a top-level window element via setAttribute, the new colors don't get applied to the window titlebar immediately.  Instead, they get applied after something else happens in the window, f.e. the window gets resized.

I've attached a simple XULRunner testcase.  It presents a button that, when pressed, runs the following code:

  document.documentElement.setAttribute("titlebarcolor", "#ff0000");
  document.documentElement.setAttribute("activetitlebarcolor", "#ff0000");
  document.documentElement.setAttribute("inactivetitlebarcolor", "#ff0000");

When you press the button in the testcase, the titlebar should turn red, but it doesn't.  If you then resize the window, however, the titlebar then turns red.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Note: Personas currently works around this problem using the following code:

  if (window.windowState != Ci.nsIDOMChromeWindow.STATE_MINIMIZED) {
    window.resizeTo(parseInt(window.outerWidth)+1, window.outerHeight);
    window.resizeTo(parseInt(window.outerWidth)-1, window.outerHeight);
  }

That's a pretty wonky experience, though, since it shakes the browser, which is jarring to users.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Attachment: xulrunner test app

Comment 3

[Josh Aas]

Can you take a look at this Markus?

Comment 4

[Markus Stange [:mstange]]

Sure.

Comment 5

[Markus Stange [:mstange]]

Attachment: fix

Comment 6

[Markus Stange [:mstange]]

pushed: http://hg.mozilla.org/mozilla-central/rev/262d44d6e425

Comment 7

[Markus Stange [:mstange]]

Comment on attachment 369637 [details] [diff] [review]
fix

trivial patch, no risk, necessary for bug 485305

Comment 8

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 369637 [details] [diff] [review]
fix

This would also be very useful on the 1.9.0 branch.

Comment 9

[Markus Stange [:mstange]]

For the 1.9.0 branch I'd have to create a new patch with changes from bug 439354.

Comment 10

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #9)
> For the 1.9.0 branch I'd have to create a new patch with changes from bug
> 439354.

Given that the majority of Personas users are likely to be on Firefox 3.0 for the next few months, that would be super-useful if it isn't too hard or risky and could land in 1.9.0.

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 369637 [details] [diff] [review]
fix

a191=beltzner

Comment 12

[Markus Stange [:mstange]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/d9785d47587a

Comment 13

[Myk Melez [:myk] [@mykmelez]]

Unrequesting ignored flag.