485461 - Add jquery to TikiWiki JS

Status: RESOLVED FIXED

(support.mozilla.org :: General, defect)

Description

[Paul Craciunoiu [:paulc]]

It'd be great if we could do any (future, at least) JS manipulation on pages through using JQuery. JQuery provides an excellent cross-browser way of doing dynamic (and not just) things, and the power/efficiency is great. It would simplify any dynamic stuff we plan to do.

As per http://doc.tikiwiki.org/tiki-index.php?page=jQuery
This is only planned for 3.0, but as optional, so it will be a while. Opinions?

Comment 1

[Bartłomiej Brzozowiec (BartZilla)]

According to http://docs.jquery.com/Browser_Compatibility "There are known problems with: (...) Konqueror". So, I vote for "no".
I run http://jquery.com/test/ with Konqueror 3.5.10 and it says: "100 tests of 1261 failed.".

Comment 2

[Majken Connor [:Kensie]]

It also says "jQuery generally works with Konqueror...but there may be some unexpected bugs"

All of the major browsers are supported and I don't believe we QA any sites for compatibility with Konqueror anyway. It doesn't sound to me like Konqueror poses a significant barrier in terms of bugs, and I would be surprised if we get enough traffic from Konqueror to block on the switch even if there are some bugs.

Comment 3

[David Tenser [:djst]]

We have a brave Konqueror user base of 0.022% on SUMO (or as Omniture proudly reports it: 0.0%)...

Comment 4

[Laura Thomson :laura]

Konqueror is not on webdev's A list - we have a frontend standard on wikimo, which I would link to if it wasn't down, grr.

Comment 5

[Paul Craciunoiu [:paulc]]

So is this on? Can we target it for the next release? (is that 1.0.1 or 1.0.2?)

Comment 6

[David Tenser [:djst]]

This will eventually block getting screencast support up, so let's definitely fix it. Not sure if it's 1.0.2 worthy yet, but we'll know more about that next week.

(1.0.1 is reserved for 3.1->3.5 and search fixes.)

Comment 7

[Paul Craciunoiu [:paulc]]

This is an easy fix, I believe. Should we set it for 1.0.2? David?

Comment 8

[Paul Craciunoiu [:paulc]]

Done. This shouldn't cause any problems yet, as it's not being actually used. The js file is simply added to the list of minify and included in the /js folder.
r24207 / r24208-9

We can push this for future if it's not 1.0.2 worthy :)

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Just to be sure, this isn't (yet) testable, right?  i.e. not implemented anywhere...

Comment 10

[David Tenser [:djst]]

Paul, please submit a patch and allow Laura to review, as discussed in today's fabulous 1.0 postmortem.

Comment 11

[Paul Craciunoiu [:paulc]]

Attachment: jquery add to minify

There we go. It's a really simple patch. I downloaded the already-minified jquery library from jquery.com and renamed it to jquery.min.js, put it in the /webroot/js folder.
Then I added that path to minify.php. I tested it locally with the JS code:
---
$(document).ready(function() {
   alert('hi');
});
---

So aside from the jquery library, I added one line of code...

Comment 12

[Marc Laporte]

jQuery is the default, always on JavaScript framework in Tiki4. It is used in compatibility mode, so specific projects can also use others (although in Tiki, it's just jQuery).

http://doc.tikiwiki.org/jQuery