Add jquery to TikiWiki JS

RESOLVED FIXED in 1.0.2

Status

support.mozilla.org
General
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: paulc, Assigned: paulc)

Tracking

({ue})

unspecified
1.0.2

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: tiki_fixed)

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
It'd be great if we could do any (future, at least) JS manipulation on pages through using JQuery. JQuery provides an excellent cross-browser way of doing dynamic (and not just) things, and the power/efficiency is great. It would simplify any dynamic stuff we plan to do.

As per http://doc.tikiwiki.org/tiki-index.php?page=jQuery
This is only planned for 3.0, but as optional, so it will be a while. Opinions?
According to http://docs.jquery.com/Browser_Compatibility "There are known problems with: (...) Konqueror". So, I vote for "no".
I run http://jquery.com/test/ with Konqueror 3.5.10 and it says: "100 tests of 1261 failed.".
It also says "jQuery generally works with Konqueror...but there may be some unexpected bugs"

All of the major browsers are supported and I don't believe we QA any sites for compatibility with Konqueror anyway. It doesn't sound to me like Konqueror poses a significant barrier in terms of bugs, and I would be surprised if we get enough traffic from Konqueror to block on the switch even if there are some bugs.

Comment 3

9 years ago
We have a brave Konqueror user base of 0.022% on SUMO (or as Omniture proudly reports it: 0.0%)...

Comment 4

9 years ago
Konqueror is not on webdev's A list - we have a frontend standard on wikimo, which I would link to if it wasn't down, grr.
(Assignee)

Comment 5

9 years ago
So is this on? Can we target it for the next release? (is that 1.0.1 or 1.0.2?)

Comment 6

9 years ago
This will eventually block getting screencast support up, so let's definitely fix it. Not sure if it's 1.0.2 worthy yet, but we'll know more about that next week.

(1.0.1 is reserved for 3.1->3.5 and search fixes.)
(Assignee)

Comment 7

9 years ago
This is an easy fix, I believe. Should we set it for 1.0.2? David?
(Assignee)

Comment 8

9 years ago
Done. This shouldn't cause any problems yet, as it's not being actually used. The js file is simply added to the list of minify and included in the /js folder.
r24207 / r24208-9

We can push this for future if it's not 1.0.2 worthy :)
Status: NEW → RESOLVED
Last Resolved: 9 years ago
OS: Windows Vista → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: Future → 1.0.2
Just to be sure, this isn't (yet) testable, right?  i.e. not implemented anywhere...
Paul, please submit a patch and allow Laura to review, as discussed in today's fabulous 1.0 postmortem.
(Assignee)

Comment 11

9 years ago
Created attachment 371595 [details] [diff] [review]
jquery add to minify

There we go. It's a really simple patch. I downloaded the already-minified jquery library from jquery.com and renamed it to jquery.min.js, put it in the /webroot/js folder.
Then I added that path to minify.php. I tested it locally with the JS code:
---
$(document).ready(function() {
   alert('hi');
});
---

So aside from the jquery library, I added one line of code...
Attachment #371595 - Flags: review?(laura)

Updated

9 years ago
Attachment #371595 - Flags: review?(laura) → review+
Keywords: push-needed
Keywords: push-needed

Comment 12

8 years ago
jQuery is the default, always on JavaScript framework in Tiki4. It is used in compatibility mode, so specific projects can also use others (although in Tiki, it's just jQuery).

http://doc.tikiwiki.org/jQuery
Whiteboard: tiki_fixed
You need to log in before you can comment on or make changes to this bug.