This means that we either have to special case this character (and possibly others) or always try to use JSON.parse first and only when it throws fall back to evalInSandbox for backwards compatibility.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Hardware: x86 → All
Summary: Sessions containing UTF-8 characters cannot be restored. → eval doesn't handle \u2028 (LINE SEPARATOR) the same as JSON.parse
Version: unspecified → 3.1 Branch
In the above I meant to say a \u2028 character. Obviously the text "\u2028" is okay.
Depends on: 387859
Summary: eval doesn't handle \u2028 (LINE SEPARATOR) the same as JSON.parse → eval doesn't handle \u2028 (LINE SEPARATOR) and \u2029 the same as JSON.parse
The correct fix for this is fixing bug 387859. Since that might be too late for Firefox 3.5 (as it would involve some of our API to become stricter in what it accepts), we'll likely have to go with this wall-paper patch instead which just makes sure that both offending characters aren't left as-is for evalInSandbox to trip over them.
Assignee: nobody → zeniko
Status: NEW → ASSIGNED
Attachment #369776 - Flags: review?(dietrich)
Comment on attachment 369776 [details] [diff] [review] wall-paper for Firefox 3.5 r=me. a concern is that this work is usually not required. maybe could test() first, and only replace if it returns true?
Attachment #369776 - Flags: review?(dietrich) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.6a1
Backed out; the push this was part of seems to be causing random leak orange on Mac.
Status: RESOLVED → REOPENED
Flags: in-testsuite+ → in-testsuite?
Resolution: FIXED → ---
Looks like the random leak orange is still happening, so this can reland as desired...
Actually, scratch that. This orange is on Linux, whereas the orange from the push this landed as part of was on Mac. I recommend landing this separately from the other 4 patches that landed with it.
The leak exists on 1.9.1, so this didn't cause it.
Status: REOPENED → RESOLVED
Last Resolved: 10 years ago → 10 years ago
Flags: in-testsuite? → in-testsuite+
Resolution: --- → FIXED
Comment on attachment 370447 [details] [diff] [review] for check-in a191=beltzner
Attachment #370447 - Flags: approval1.9.1? → approval1.9.1+
This doesn't work anymore. If HTML contains that character - firefox does not show it for chars u2028 and u2029. Steps: 1. Please open in Chrome and Firefox the same page https://unicode-table.com/ru/2029/ Actual Result: Firefox does not show that characters. Expected result: Firefox shows that char as Chrome does. Thanks.
You need to log in before you can comment on or make changes to this bug.