485576 - Fix a few minor gcc warnings in jsemit, jsexn, jsopcode, jsxml

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Andrew Paprocki]

Attachment: patch to fix gcc warnings

Fixes one -Wredundant-decls (exn_finalize declared twice) and a few -Wextra (enumerator and a non-enumerator both appear in a conditional expression) warnings.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Thanks! http://hg.mozilla.org/tracemonkey/rev/20a983740d48

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Oops, fixed-in-tracemonkey, not yet on mozilla-central.

Comment 3

[Brendan Eich [:brendan]]

Comment on attachment 369714 [details] [diff] [review]
patch to fix gcc warnings

>+    ss->opcodes[top] = (op == JSOP_GETPROP2) ? (jsbytecode) JSOP_GETPROP
>+                     : (op == JSOP_GETELEM2) ? (jsbytecode) JSOP_GETELEM
>                      : (jsbytecode) op;

Drive-by, belated: write jsbytecode(...) once, on the outside.

>+    switch (vxml ? (JSXMLClass) vxml->xml_class : JSXML_CLASS_LIMIT) {

C++ constructor-style cast here too.

/be

Comment 4

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/20a983740d48

Comment 5

[Robert Sayre]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/bb1ac8c1775c