Closed Bug 485592 Opened 15 years ago Closed 15 years ago

nsTextToSubURI::UnEscapeAndConvert uses mismatched allocators

Categories

(Core :: Internationalization, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

Details

Attachments

(1 file, 1 obsolete file)

char *unescaped = nsCRT::strdup((char *) text);

does not match

PR_Free(unescaped);
Attached patch Standardise on NS_ versions (obsolete) — Splinter Review
Assignee: smontagu → neil
Status: NEW → ASSIGNED
Attachment #369733 - Flags: superreview?(jag)
Attachment #369733 - Flags: review?(smontagu)
Attachment #369733 - Flags: superreview?(jag) → superreview+
Hrm. On second though, PR_Malloc, nsMemory::Alloc and with this change NS_Alloc all three in one file. Can we pick one?
It turns out there was another PR_Malloc'd outparam to be changed anyway.
Attachment #369733 - Attachment is obsolete: true
Attachment #371329 - Flags: superreview?(jag)
Attachment #371329 - Flags: review?(smontagu)
Attachment #369733 - Flags: review?(smontagu)
Attachment #371329 - Flags: superreview?(jag) → superreview+
Attachment #371329 - Flags: review?(smontagu) → review+
Pushed changeset 62e0aedc34c3 to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: