Closed
Bug 485598
Opened 15 years ago
Closed 15 years ago
nsImageRequestProxy violates XPCOM calling conventions
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
Details
Attachments
(1 file)
|
693 bytes,
patch
|
joe
:
review+
jag+mozilla
:
superreview+
|
Details | Diff | Splinter Review |
GetMimeType should use NS_strdup, not nsCRT::strdup, for its outparam.
|
Assignee | |
Comment 1•15 years ago
|
||
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #369738 -
Flags: superreview?(jag)
Attachment #369738 -
Flags: review?(joe)
|
||
Updated•15 years ago
|
Attachment #369738 -
Flags: superreview?(jag) → superreview+
|
|
||
Comment 2•15 years ago
|
||
Comment on attachment 369738 [details] [diff] [review] Proposed patch You can probably remove the nsCRT.h include then.
|
||
Comment 3•15 years ago
|
||
Comment on attachment 369738 [details] [diff] [review] Proposed patch Does this cause real bugs, or is it just a correctness issue?
Attachment #369738 -
Flags: review?(joe) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
It might help us enable jemalloc on the Mac.
|
|
Assignee | |
Comment 5•15 years ago
|
||
Pushed changeset 5078614a3c1f to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•