nsImageRequestProxy violates XPCOM calling conventions

RESOLVED FIXED

Status

()

Core
ImageLib
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

693 bytes, patch
Joe Drew (not getting mail)
: review+
jag (Peter Annema)
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

9 years ago
GetMimeType should use NS_strdup, not nsCRT::strdup, for its outparam.
(Assignee)

Comment 1

9 years ago
Created attachment 369738 [details] [diff] [review]
Proposed patch
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #369738 - Flags: superreview?(jag)
Attachment #369738 - Flags: review?(joe)

Updated

9 years ago
Attachment #369738 - Flags: superreview?(jag) → superreview+

Comment 2

9 years ago
Comment on attachment 369738 [details] [diff] [review]
Proposed patch

You can probably remove the nsCRT.h include then.
Comment on attachment 369738 [details] [diff] [review]
Proposed patch

Does this cause real bugs, or is it just a correctness issue?
Attachment #369738 - Flags: review?(joe) → review+
(Assignee)

Comment 4

9 years ago
It might help us enable jemalloc on the Mac.
(Assignee)

Comment 5

9 years ago
Pushed changeset 5078614a3c1f to mozilla-central.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.