Closed
Bug 485605
Opened 16 years ago
Closed 16 years ago
nsJSID will need to use NS_Free to free the result of nsID::ToString
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
References
Details
Attachments
(2 files)
|
814 bytes,
patch
|
mrbkap
:
review+
jag+mozilla
:
superreview+
|
Details | Diff | Splinter Review |
|
2.75 KB,
patch
|
mrbkap
:
review+
jag+mozilla
:
superreview+
|
Details | Diff | Splinter Review |
As per bug 331165, nsID::ToString should use the XPCOM allocator.
nsJSID therefore needs to use the XPCOM deallocator.
|
Assignee | |
Comment 1•16 years ago
|
||
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #369744 -
Flags: superreview?(jag)
Attachment #369744 -
Flags: review?(mrbkap)
|
||
Updated•16 years ago
|
Attachment #369744 -
Flags: review?(mrbkap) → review+
|
|
Assignee | |
Comment 2•16 years ago
|
||
Attachment #369751 -
Flags: superreview?(jag)
Attachment #369751 -
Flags: review?(mrbkap)
|
||
Updated•16 years ago
|
Attachment #369744 -
Flags: superreview?(jag) → superreview+
|
|
||
Comment 3•16 years ago
|
||
Comment on attachment 369751 [details] [diff] [review]
Cleanup patch
I prefer this version.
Attachment #369751 -
Flags: superreview?(jag) → superreview+
|
|
||
Comment 4•16 years ago
|
||
Comment on attachment 369751 [details] [diff] [review]
Cleanup patch
>diff -r 8d2c566f3256 js/src/xpconnect/src/xpcjsid.cpp
>+ return mName ? PR_TRUE : PR_FALSE;
I'd prefer to see this written as
return mName != nsnull;
r=mrbkap either way.
Attachment #369751 -
Flags: review?(mrbkap) → review+
|
|
Assignee | |
Comment 5•16 years ago
|
||
Pushed changeset 8fd479d48386 to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•