Closed
Bug 485628
Opened 15 years ago
Closed 15 years ago
Clean up mozStorageService.* to match what is in the style guidelines
Categories
(Toolkit :: Storage, defect)
Toolkit
Storage
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: sdwilsh, Assigned: sdwilsh)
References
Details
Attachments
(1 file, 2 obsolete files)
|
23.36 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•15 years ago
|
||
This is supposedly a -w diff, but I'm a bit skeptical...
Attachment #369786 -
Flags: review?(bugmail)
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [needs review asuth]
|
||
Updated•15 years ago
|
Attachment #369786 -
Flags: review?(bugmail) → review+
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [needs review asuth] → [can land]
|
|
Assignee | |
Comment 2•15 years ago
|
||
This doesn't build in static builds. Trying to figure out why...
Whiteboard: [can land]
|
|
Assignee | |
Comment 3•15 years ago
|
||
This has a minor change, but still doesn't build, and I'm not sure why...
Attachment #369786 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•15 years ago
|
||
The error I'm getting is:
Undefined symbols:
"mozStorageModule_NSGetModule(nsIComponentManager*, nsIFile*, nsIModule**)", referenced from:
_gStaticModuleInfo in nsStaticXULComponents.o|
|
Assignee | |
Comment 5•15 years ago
|
||
Uploading to bugzilla and looking at the diff again showed me the error in my ways. Not asking for review because the change was very minimal.
Attachment #370072 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [can land]
|
|
Assignee | |
Comment 6•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/98fd92d1d41e
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [can land]
Target Milestone: --- → mozilla1.9.2a1
You need to log in
before you can comment on or make changes to this bug.
Description
•