485834 - ObserverService shouldn't recurse infinitely for stupid consumers

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[timeless]

Attachment: protect against stupidity

So, bug 325392 shows an example of a stupid consumer.

NS_IMPL_ISUPPORTS1(nsBroken, nsIObserver)

nsBroken::nsBroken() {
  nsCOMPtr<nsIObserverService>
    os(do_GetService("@mozilla.org/observer-service;1"));
  os->AddObserver(this, "stupid", PR_FALSE);
}

nsBroken::~nsBroken() {
  nsCOMPtr<nsIObserverService>
    os(do_GetService("@mozilla.org/observer-service;1"));
  os->RemoveObserver(this, "stupid");
}

NS_IMETHODIMP
nsBroken::Observe(
  nsISupports*     subject,
  const char*      topic,
  const PRUnichar* data_unicode)
{
  return NS_OK;
}

Comment 1

[(not currently active) Ted Mielczarek]

Comment on attachment 369926 [details] [diff] [review]
protect against stupidity

I am not qualified to review this.

Comment 2

[chris hofmann]

dougt maybe?

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 369926 [details] [diff] [review]
protect against stupidity

add a comment to the reason you need the death grip.

Comment 4

[timeless]

http://hg.mozilla.org/mozilla-central/rev/9b612b23ae16