485835 - tabs close button also needs a bottom margin (browser.tabs.closeButtons=3)

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Dão Gottwald [:dao]]

+++ This bug was initially created as a clone of Bug #483983 +++

In bug 478625, a bottom margin has been added to the new-tab button, so that it doesn't touch the tabstrip border. The same needs to be done for the tabs close button.

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

Comment 2

[Michael Ventnor]

+.tabs-container > toolbarbutton,
+.tabbrowser-arrowscrollbox > toolbarbutton {

Why this? Is there more than one toolbarbutton that needs this rule>

Comment 3

[Michael Ventnor]

s/>/?

Comment 4

[Michael Ventnor]

Let me clarify that; you can't just use a class name instead of the > selector?

Comment 5

[Dão Gottwald [:dao]]

Attachment: patch v2

You're right, .tabbrowser-arrowscrollbox > toolbarbutton didn't make much sense. I think it actually applied to the arrow scroll buttons (although it was overwritten elsewhere), which we don't want.

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 371414 [details] [diff] [review]
patch v2

>+.tabs-alltabs-button,
>+.tabs-container > toolbarbutton {
>+  margin-bottom: 1px;
>+}

Note that I'd like to get rid of the alltabs stack in the near future, so .tabs-container > toolbarbutton would also apply to the alltabs button, and .tabs-alltabs-button could be removed.

Comment 7

[Michael Ventnor]

Is tabs-container what contains the actual tab elements? Its just that my concern is a user with many open tabs will cause that selector to run more slowly, and I'm wondering if there's a way to use class names only instead of that selector.

Comment 8

[Dão Gottwald [:dao]]

Attachment: patch v3

tabs-container doesn't contain the tabs, but I have no opinion against doing it this way.

Comment 9

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/fb93c005e279

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 371629 [details] [diff] [review]
patch v3

a191=beltzner

Comment 11

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/dc28d72f7940

Comment 12

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090526 Minefield/3.6a1pre ID:20090526031623

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090526 Shiretoko/3.5pre ID:20090526031155

Comment 13

[Aakash Desai [:aakashd]]

actually, this is on linux,

verified FIXED on builds: 


Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1pre) Gecko/20090526 Shiretoko/3.5pre ID:20090526031235


and

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2pre) Gecko/20090526 Firefox 3.6a1pre ID:20090526031312

Comment 15

[Alex Faaborg [:faaborg] (Firefox UX)]

This bug's priority relative to the set of other polish bugs is:
P1 - Polish issue that appears in the main window, or is something that the user may encounter several times a day.