Open Bug 485857 Opened 15 years ago Updated 2 years ago

xpcom: -DXP_MACOSX not provided to xpcom/base/nsStackWalk.cpp

Categories

(Firefox :: General, defect)

x86
macOS
defect

Tracking

()

People

(Reporter: jeremyhu, Unassigned)

Details

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3) Gecko/20090305 Firefox/3.1b3
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3) Gecko/20090305 Firefox/3.1b3

xpcom/base/nsStackWalk.cpp has an #ifdef XP_MACOSX pre-processor check.  This is supposed to be set by HOST_CFLAGS in configure, but xpcom/base/Makefile.in doesn't make use of this variable.

make showhost shows (as expected):
HOST_CFLAGS        = -O2 -DXP_UNIX -DXP_MACOSX -O2

Also, HOST_CXXFLAGS is the same as HOST_CFLAGS as we make this modification to configure:
 *-darwin*)
-    HOST_CFLAGS="$HOST_CFLAGS -DXP_UNIX -DXP_MACOSX -DNO_X11"
-    HOST_NSPR_MDCPUCFG='\"md/_darwin.cfg\"'
+    HOST_CFLAGS="$HOST_CFLAGS -DXP_UNIX -DXP_MACOSX"
+    HOST_CXXFLAGS="$HOST_CXXFLAGS -DXP_UNIX -DXP_MACOSX"
     HOST_OPTIMIZE_FLAGS="${HOST_OPTIMIZE_FLAGS=-O3}"
     MOZ_FIX_LINK_PATHS='-Wl,-executable_path,$(LIBXUL_DIST)/bin'
-    LIBXUL_LIBS='$(XPCOM_FROZEN_LDOPTS) $(LIBXUL_DIST)/bin/XUL -lobjc'
     ;;
 


Reproducible: Always
Assignee: nobody → jeremyhu
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
I thought this was a HOST_CFLAGS issue based on my understanding of BUILD/HOST/TARGET ... Now that I've been informed that mozilla is using the incorrect vartiables for legacy reasons (TARGET instead of HOST and HOST instead of BUILD), it looks more like a case of -DXP_MACOSX just not being in the TARGET_CFLAGS...
Summary: xpcom: HOST_CFLAGS not provided to xpcom/base/nsStackWalk.cpp → xpcom: -DXP_MACOSX not provided to xpcom/base/nsStackWalk.cpp

The bug assignee didn't login in Bugzilla in the last 7 months.
:mossop, could you have a look please?
For more information, please visit auto_nag documentation.

Assignee: jeremyhu → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(dtownsend)
Flags: needinfo?(dtownsend)
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.