Closed Bug 485868 Opened 11 years ago Closed 11 years ago

Eliminate code duplication in xpcjsruntime.cpp

Categories

(Core :: XPConnect, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: mrbkap, Assigned: mrbkap)

Details

Attachments

(1 file)

Attached patch Proposed fixSplinter Review
Sayrer pointed out that we duplicate some (hard to get right) code. We should fix that.

I don't know if this patch passes our C++ portability guidelines, yet. But sayrer prodded me into getting a bug on file for it.
Attachment #369968 - Flags: superreview?(brendan)
Attachment #369968 - Flags: review?(jst)
Assignee: nobody → mrbkap
Attachment #369968 - Flags: superreview?(brendan) → superreview+
Comment on attachment 369968 [details] [diff] [review]
Proposed fix

Beats using a macro :-P.

/be
Comment on attachment 369968 [details] [diff] [review]
Proposed fix

Probably worth a spin through the try-servers before landing, but looks good.
Attachment #369968 - Flags: review?(jst) → review+
http://hg.mozilla.org/mozilla-central/rev/a09f2e4f26cf
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.