485871 - ChatZilla should use the python version of compare-locales

Status: NEW

(Other Applications :: ChatZilla, defect)

Description

[Atsushi Sakai]

Spun off form bug 485692 comment #5.

ChatZilla uses compare-locales.pl now but should use the python version of compare-locales instead.

Comment 1

[Axel Hecht [:Pike]]

http://hg.mozilla.org/build/compare-locales/ is the repo for compare-locales now, there are probably a few patches needed to it to do what chatzilla (and venkman?) need.

In particular, I assume that you may not need to create an app for the two, but just want to compare directories, at which point I don't think filter.py is hooked up yet. And you probably want to do something like an sys.exit(1) on missing strings, I might add that already for Firefox, though.

Comment 2

[Adrian Kalla [:adriank]]

Lets remove a decade of dust here...

The latest ChatZilla update to version 0.9.93 resulted in the SeaMonkey repacks failing because of missing strings. Switching to the modern compare-locales adds the L10n merge ability, so I decided to try and just do this.

Two patches are needed: one for the ChatZilla repo, one for the SeaMonkey one. I admit: I have pretty much no clue about makefiles so I hacked this together and at first it seems to work. A full build is running now to confirm that.

Comment 3

[Adrian Kalla [:adriank]]

Attachment: chatzilla_compare_part1.patch

Comment 4

[Adrian Kalla [:adriank]]

Attachment: chatzilla_compare_part2.patch

Comment 5

[Adrian Kalla [:adriank]]

Attachment: chatzilla_compare_part1_v0.2.patch

Comment 6

[Adrian Kalla [:adriank]]

Attachment: chatzilla_compare_part2_v0.2.patch

Comment 7

[Adrian Kalla [:adriank]]

With the v0.2 patches c-r builds with ChatZilla 0.9.93 and L10n-merge for ChatZilla does work too.

Comment 8

[Adrian Kalla [:adriank]]

Attachment: chatzilla_compare_part1_v0.3.patch

It was a bad idea to have the LOCALE_MERGEDIR var point to different dirs (merge_dir vs merge_dir/irc), as somehow this gets mixed up and at the end breaks the L10n merge for other components (e.g. Lightning)... Fixed with revision 0.3.

Comment 9

[Adrian Kalla [:adriank]]

Attachment: chatzilla_compare_part2_v0.3.patch