Open Bug 485871 Opened 11 years ago Updated 3 years ago

ChatZilla should use the python version of compare-locales

Categories

(Other Applications :: ChatZilla, defect)

defect
Not set

Tracking

(Not tracked)

People

(Reporter: dev-null, Assigned: adriank)

Details

Attachments

(2 files, 4 obsolete files)

Spun off form bug 485692 comment #5.

ChatZilla uses compare-locales.pl now but should use the python version of compare-locales instead.
http://hg.mozilla.org/build/compare-locales/ is the repo for compare-locales now, there are probably a few patches needed to it to do what chatzilla (and venkman?) need.

In particular, I assume that you may not need to create an app for the two, but just want to compare directories, at which point I don't think filter.py is hooked up yet. And you probably want to do something like an sys.exit(1) on missing strings, I might add that already for Firefox, though.
Lets remove a decade of dust here...

The latest ChatZilla update to version 0.9.93 resulted in the SeaMonkey repacks failing because of missing strings. Switching to the modern compare-locales adds the L10n merge ability, so I decided to try and just do this.

Two patches are needed: one for the ChatZilla repo, one for the SeaMonkey one. I admit: I have pretty much no clue about makefiles so I hacked this together and at first it seems to work. A full build is running now to confirm that.
Assignee: rginda → akalla
Attached patch chatzilla_compare_part1.patch (obsolete) — Splinter Review
Attachment #8812598 - Flags: feedback?(iann_bugzilla)
Attached patch chatzilla_compare_part2.patch (obsolete) — Splinter Review
Attachment #8812599 - Flags: feedback?(iann_bugzilla)
Attachment #8812598 - Attachment is obsolete: true
Attachment #8812598 - Flags: feedback?(iann_bugzilla)
Attachment #8812864 - Flags: feedback?(iann_bugzilla)
Attachment #8812599 - Attachment is obsolete: true
Attachment #8812599 - Flags: feedback?(iann_bugzilla)
Attachment #8812865 - Flags: feedback?(iann_bugzilla)
With the v0.2 patches c-r builds with ChatZilla 0.9.93 and L10n-merge for ChatZilla does work too.
It was a bad idea to have the LOCALE_MERGEDIR var point to different dirs (merge_dir vs merge_dir/irc), as somehow this gets mixed up and at the end breaks the L10n merge for other components (e.g. Lightning)... Fixed with revision 0.3.
Attachment #8812864 - Attachment is obsolete: true
Attachment #8812864 - Flags: feedback?(iann_bugzilla)
Attachment #8817131 - Flags: feedback?(iann_bugzilla)
Attachment #8812865 - Attachment is obsolete: true
Attachment #8812865 - Flags: feedback?(iann_bugzilla)
Attachment #8817132 - Flags: feedback?(iann_bugzilla)
You need to log in before you can comment on or make changes to this bug.