485902 - Firefox should feed text around cursor when requested by IME

Status: RESOLVED DUPLICATE of bug 532130

(Core :: Widget: Win32, enhancement)

Description

[nag]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b3) Gecko/20090309 Firefox/3.0 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b3) Gecko/20090309 Firefox/3.0 (.NET CLR 3.5.30729)

To improve accuracy of IME conversion during typing,
Firefox should feed text around cursor when requested by IME.
This feature is indispensable
for text editing on Firefox as an application platform.

TSF, new IME API on Windows, naturally offer this function.
(TSF is now under development. See Bug 88831 and related topics.)
But traditional IMM32 IME, such as ATOK,
require another patch to reply to WM_IME_REQUEST/IMR_DOCUMENTFEED message.


Reproducible: Always

Comment 1

[nag]

Attachment: patch

Comment 2

[Ere Maijala (slow)]

Comment on attachment 369994 [details] [diff] [review]
patch

+    *oResult = sizeof(RECONVERTSTRING) + 2 * MAX_CONTEXT_CHARS * sizeof(WCHAR);

Could you explain why you need 2 * MAX_CONTEXT_CHARS? Maybe I'm just confused and MSDN doesn't really help describing IMR_DOCUMENTFEED.

Comment 3

[nag]

IME need "a few" chars befor cursor and "a few" chars after cursor.
I defined this "a few" as MAX_CONTEXT_CHARS,
so the total is 2*MAX_CONTEXT_CHARS.

I guess 20 is reasonable and enough number for MAX_CONTEXT_CHARS,
because a "bunsetsu" usually contains 2 ~ 8 chars in Japanese.

Comment 4

[Ere Maijala (slow)]

Would it make sense to say that MAX_CONTENT_CHARS is 40 then?

Comment 5

[Ere Maijala (slow)]

Comment on attachment 369994 [details] [diff] [review]
patch

r- due to no feedback. I think it would be more clear if MAX_CONTEXT_CHARS would be 40 and you'd take half of that from each side.