Closed
Bug 485932
Opened 16 years ago
Closed 16 years ago
[vi] Remove google.xml and creativecommons.xml from browser/searchengines/
Categories
(Mozilla Localizations :: vi / Vietnamese, defect)
Mozilla Localizations
vi / Vietnamese
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stas, Unassigned)
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
|
4.49 KB,
patch
|
stas
:
review+
|
Details | Diff | Splinter Review |
Since we're using the same plug-in file as in en-US, we don't need a duplicate in vi/browser/searchplugins. The code picks the en-US version anyways, so maintaining this file in vi/ isn't necessary.
Please attach a patch and request a review. Thanks.
Before making the patch, I'd like to ask if we should remove creativecommons.xml as well? The CC search plugin file in vi is the same as the en-US one.
| Reporter | ||
Comment 2•16 years ago
|
||
Good catch, Hung. Yes, please remove CC too.
Summary: [vi] Remove google.xml from browser/searchengines/ → [vi] Remove google.xml and creativecommons.xml from browser/searchengines/
Here is the patch for removing those two files.
Attachment #370014 -
Flags: review?(stas)
| Reporter | ||
Comment 4•16 years ago
|
||
Comment on attachment 370014 [details] [diff] [review]
Remove google.xml and creativecommons.xml
r=me. Please land this on both branches with a descriptive check-in comment mentioning the bug number and my review.
Use fixed1.9.1 and verified1.9.1 to track landing and the following verification on the 1.9.1 branch.
Thanks!
Attachment #370014 -
Flags: review?(stas) → review+
Done.
http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/vi/rev/21ef64937cda
You can mark this bug as fixed.
Thank you, Stas :)
| Reporter | ||
Comment 6•16 years ago
|
||
Thanks Hung. Marking as fixed.
URL to the landing on l10n-central:
http://hg.mozilla.org/l10n-central/vi/rev/ede174705f3c
You need to log in
before you can comment on or make changes to this bug.
Description
•