485936 - Change case of selected characters by keypress or menu item

Status: RESOLVED FIXED

(Skywriter Graveyard :: Editor, enhancement, P4)

Description

[Marco Warga]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.0.6) Gecko/2009011913 Firefox/3.0.6
Build Identifier: 

Changing the case of all currently selected characters to upper or lower case by pressing a key combination or chosing a menu option.

MS Visual Studio 97-2008: Press LCTRL+LSHIFT+U or LCTRL+LSHIFT+L resp.
Notepad2 (http://www.flos-freeware.ch): same as above
Textpad (http://www.textpad.com): use menu option


Reproducible: Always

Comment 1

[Gordon P. Hemsley [:GPHemsley]]

Definitely a feature that I would want. Confirming.

Comment 2

[Sean Burke]

I have started to play around with this and hopefully should have something working shortly. I am currently having issues getting any new clone to work do to a bootstrap.py issue so this may back me up a bit.

Plan:
1.) Get the base code working so that the enhancement is working correctly
2.) Add undo/redo support
3.) If/When block selection is added, code in support for it.

Comment 3

[Sean Burke]

Attachment: Bundle for changes

Bundle for changes, so far has passed the tests I have given it however since this is my first shot messing with undo/redo in actions there may be some unexpected behavior.

Comment 4

[Dion Almaer]

Hi Sean,

I pushed this in changeset #dc1c9d1373a5.

What I would like to see:

- This works in simple cases (highlight a word) but I get bugs when I do things like go across lines. Then the newline seems to get swallowed and the lines join. Do you see that behaviour?

- It would be nice to have commands that map to this: either "uc" and "lc" or "toupper" and "tolower" (could use "alias: 'uc'" to uc/lc). In the commands you could then have 'withKey: "CTRL SHIFT u"' and move that out of the bindlistener section.

Mind doing this work? You should be able to hg pull -u to get to the latest.

Cheers,

Dion

Comment 5

[Sean Burke]

Attachment: Fix for selectionChangeCase not working across rows correctly

Comment 6

[Sean Burke]

I plan to work on the command portion of this now :)

Comment 7

[Gordon P. Hemsley [:GPHemsley]]

Dion, RESOLVED INCOMPLETE is not for partially-fixed bugs!

Comment 8

[Dion Almaer]

Sean,

FYI: Multi-line is working for the action, but if you "undo" then it goes back and munges the lines still.

Comment 9

[Sean Burke]

Odd undo was working for me, I probably messed something up before I committed. Will attempt to work on it more once I can connect to my nix box again.

Comment 10

[Gordon P. Hemsley [:GPHemsley]]

The main bug is fixed, so marking it as RESOLVED FIXED.

The undo/redo bug has been popped out into bug 486912.

Comment 11

[Gordon P. Hemsley [:GPHemsley]]

This is a mass migration from Mozilla Labs :: Bespin to Bespin :: Editor.