Closed
Bug 486049
Opened 15 years ago
Closed 15 years ago
TM: maintain globalShape in VMFragment only, not in TreeInfo and VMFragment
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: gal, Assigned: gal)
References
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
|
12.24 KB,
patch
|
graydon
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•15 years ago
|
||
Assignee: general → gal
|
|
Assignee | |
Comment 2•15 years ago
|
||
split out cleanup part from bug this blocks (no change in behavior from this patch)
|
|
Assignee | |
Updated•15 years ago
|
Attachment #370124 -
Flags: review?(graydon)
|
||
Updated•15 years ago
|
Attachment #370124 -
Flags: review?(graydon) → review+
|
|
||
Comment 3•15 years ago
|
||
Comment on attachment 370124 [details] [diff] [review] patch I don't really see why this is an important change to make, but it looks like it does what is claims. r+ assuming it works.
|
|
Assignee | |
Comment 4•15 years ago
|
||
I am adding a second feature of the global object to track: its identity. I have to either add it to two places redundantly, and make all the code find and update it in both places, or we stop having the shape in TreeInfo and just in VMFragment, at which point I only add the object identity to VMFragment.
|
||
Comment 5•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/246bb72c6c11
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
||
Comment 6•15 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f16398528b1f
Keywords: fixed1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•