Closed Bug 486052 Opened 12 years ago Closed 12 years ago

[FIX]"ASSERTION: unexpected second call to SetInitialChildList" with r&a pos, table-footer-group

Categories

(Core :: Layout: Positioned, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jruderman, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, regression, testcase)

Attachments

(2 files)

Attached file testcase
###!!! ASSERTION: unexpected second call to SetInitialChildList: 'Not Reached', file /Users/jruderman/central/layout/generic/nsContainerFrame.cpp, line 111

###!!! ASSERTION: Frames getting lost!: 'NS_SUCCEEDED(rv)', file /Users/jruderman/central/layout/base/nsCSSFrameConstructor.cpp, line 1320

###!!! ASSERTION: Some objects allocated with AllocateFrame were not freed: 'mFrameCount == 0', file /Users/jruderman/central/layout/base/nsPresShell.cpp, line 681

Security-sensitive because the last assertion is often scary and I'm in a hurry.
Looks like a regression; I don't see this in 1.9.1 builds.
Keywords: regression
This is a regression from bug 482889.  I forgot the FCDATA_SKIP_ABSPOS_PUSH for captions, rowgroups, and colgroups...  Nice catch, Jesse.

Removing security flag; this is trunk-only.
Assignee: nobody → bzbarsky
Blocks: 482889
Group: core-security
Status: NEW → ASSIGNED
Summary: "ASSERTION: unexpected second call to SetInitialChildList" with r&a pos, table-footer-group → [FIX]"ASSERTION: unexpected second call to SetInitialChildList" with r&a pos, table-footer-group
Attached patch Like soSplinter Review
Attachment #370137 - Flags: superreview?(roc)
Attachment #370137 - Flags: review?(roc)
Attachment #370137 - Flags: superreview?(roc)
Attachment #370137 - Flags: superreview+
Attachment #370137 - Flags: review?(roc)
Attachment #370137 - Flags: review+
Pushed http://hg.mozilla.org/mozilla-central/rev/2e7a9959dd5b
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.