486073 - JSON webservice does not display errors properly under mod_perl

Status: RESOLVED FIXED

(Bugzilla :: WebService, defect)

Description

[Max Kanat-Alexander]

In bug 432907 comment 18, dkl mentions that error messages are not properly sent under mod_perl when using the JSON WebServices interface.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Okay, wow, this was a tough one, but I figured it out! :-) The problem under mod_perl was that we were returning the error message twice, because "exit" was being trapped by the JSON-RPC Server eval under mod_perl (under mod_perl, "exit" is actually an exception).

I changed the architecture we're using to send errors to a simpler, more standard way of using JSON::RPC, which is to simply call raise_error and then just die, and let JSON::RPC return the error message itself in its own code.

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 427685 [details] [diff] [review]
v1

Looks good and works for me. r=dkl

Comment 3

[Max Kanat-Alexander]

  Thanks for the review, dkl!

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified Bugzilla/Error.pm
Committed revision 7022.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/                         
modified Bugzilla/Error.pm
Committed revision 6996.