486137 - less xpconnect stuff in browser.js

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[(dormant account)]

Attachment: less .interfaces .classes nonsense and some resize stuff

this halves the amount of time spent in resizehandler during fake resizes and otherwise speeds things up.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 370222 [details] [diff] [review]
less .interfaces .classes nonsense and some resize stuff

>       // Cache the override service the first time we need to check it
>       if (!this._overrideService)
>-        this._overrideService = Components.classes["@mozilla.org/security/certoverride;1"]
>-                                          .getService(Components.interfaces.nsICertOverrideService);
>+        this._overrideService = Cc["@mozilla.org/security/certoverride;1"]
>+                                          .getService(Ci.nsICertOverrideService);

put .getService on the same line as the Cc

>   toggleAllowPopupsForSite: function (aEvent)
>   {
>     var currentURI = Browser.selectedBrowser.webNavigation.currentURI;
>-    var pm = Components.classes["@mozilla.org/permissionmanager;1"]
>+    var pm = Cc["@mozilla.org/permissionmanager;1"]
>                        .getService(this._kIPM);

put .getService on the same line as the Cc

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

did this land?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

yep: http://hg.mozilla.org/mobile-browser/rev/24e8e65471f7