48616 - Typo in nsHTMLInputElement::HandleDOMEvent

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Look at this line:

  if (formControlFrame && 
NS_SUCCEEDED(formControlFrame->QueryInterface(kIFrameIID, (void **)&formFrame) 
&& formFrame))

Visual C++ compiler says this line is nonsense, and I agree. It looks like a 
closing parenthesis is in a wrong place, i.e. move the last closing parenthesis 
to before the last '&&'. And actually, according to COM, QI MUST ALWAYS set the 
outgoing pointer to null if the interface is not supported so the last null 
check is redundant.

I didn't just go and fix this 'cos I do not know how to actually test if it 
works or breaks something... The code is wrong in any case, and must be fixed.

Comment 1

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Nominating for nsbeta3. Trivial fix.

Comment 2

[Simon Fraser [no longer active]]

beppe: please + this. It's a trivial fix.

Comment 3

[rubydoo123]

it's nsbeta3+

Comment 4

[Simon Fraser [no longer active]]

Fix checked into 

nsHTMLInputElement.cpp
nsHTMLOptGroupElement.cpp
nsHTMLSelectElement.cpp
nsHTMLTextAreaElement.cpp

Comment 5

[sujay]

marking verified.