486239 - [Oracle] Missing keyword RESTRICT on fk creation (DB::Schema explicitly specified DELETE => 'RESTRICT')

Status: RESOLVED FIXED

(Bugzilla :: Database, defect)

Description

[Xiaoou]

Oracle is default with "ON DELETE RESTRICT" for a fk constraint, but it doesn't have a RESTRICT keyword

Comment 1

[Xiaoou]

Attachment: v1

Comment 2

[Max Kanat-Alexander]

I just realized that this isn't the right solution. For some reason, somebody explicitly specified RESTRICT in the DB Schema, which they shouldn't have done, since it's the default. We just have to remove that explicit setting, and then we should be good to go, I'm pretty sure. Although this patch won't *hurt* certainly, in case somebody does this same thing again in the future.

Comment 3

[Max Kanat-Alexander]

Attachment: v1

I'm just going to grant myself review on this. Even though this is going onto a stable branch, it's a one-line change, and I really think this is OK (and I really want to check this bug in because it causing landfill to send me an email every hour).

Comment 4

[Max Kanat-Alexander]

Turns out the problem was only on HEAD, not even on 3.4. So I just patched HEAD. I applied both patches.

Checking in Bugzilla/DB/Schema.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Schema.pm,v  <--  Schema.pm
new revision: 1.115; previous revision: 1.114
done
cd ../mkChecking in Bugzilla/DB/Schema/Oracle.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Schema/Oracle.pm,v  <--  Oracle.pm
new revision: 1.10; previous revision: 1.9
done

Comment 5

[Frédéric Buclin]

This was introduced by bug 462068, which you reviewed, Max. ;) And yes, the patch landed in 3.5 only.

Comment 6

[Max Kanat-Alexander]

(In reply to comment #5)
> This was introduced by bug 462068, which you reviewed, Max. ;)

  Um, I knew that. Was there some reason to point it out?