If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

nsScriptSecurityManager getService call chain shouldn't rely on intl/stringbundle

NEW
Assigned to

Status

()

Core
Security: CAPS
--
major
9 years ago
5 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

(Blocks: 1 bug)

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 370408 [details] [diff] [review]
change caps not to be fatalistic

i'd like to replace stringbundle w/ a js impl, but i can't, because when i run xpcshell if the contract is registered to my js impl, i get this:

NS_DebugBreak_P("Recursive GetService!"
nsComponentManagerImpl::GetServiceByContractID
CallGetService("@mozilla.org/scriptsecuritymanager;1"
nsGetServiceByContractID::operator()
mozJSComponentLoader::ReallyInit
mozJSComponentLoader::LoadModule
nsFactoryEntry::GetFactory
nsComponentManagerImpl::CreateInstanceByContractID
nsComponentManagerImpl::GetServiceByContractID
CallGetService("@mozilla.org/intl/stringbundle;1"
nsGetServiceByContractIDWithError::operator()
nsScriptSecurityManager::Init
nsScriptSecurityManager::GetScriptSecurityManager
Construct_nsIScriptSecurityManager
nsGenericFactory::CreateInstance
nsComponentManagerImpl::CreateInstanceByContractID
nsComponentManagerImpl::GetServiceByContractID
xpcom_core!CallGetService("@mozilla.org/scriptsecuritymanager;1"
xpcom_core!nsGetServiceByContractID::operator()
nsXPConnect::GetBackstagePass
main
Attachment #370408 - Flags: review?(jst)
Comment on attachment 370408 [details] [diff] [review]
change caps not to be fatalistic

Clearing out old reviews. If this is still relevant, please re-request review for this patch.
Attachment #370408 - Flags: review?(jst)
Severity: normal → major
You need to log in before you can comment on or make changes to this bug.