Closed Bug 486333 Opened 15 years ago Closed 14 years ago

Allow engine selection when setting up additional machines

Categories

(Firefox :: Sync, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: Mardak, Assigned: mconnor)

References

Details

(Keywords: uiwanted)

Attachments

(1 file)

Bug 480057 added a way to pick the direction to sync but it applied to every engine. We should populate the drop-down with enabled engines.
Target Milestone: -- → 1.0
Component: Weave → General
Product: Mozilla Labs → Weave
Version: Trunk → unspecified
QA Contact: weave → general
No longer blocks: 486331
Priority: -- → P2
Component: General → Firefox UI
QA Contact: general → firefox
Target Milestone: 1.0 → 1.3
Since we close the prefwindow once Weave is set up, there's no chance for the user to fix this.
Flags: blocking-weave1.3+
Keywords: uiwanted
Priority: P2 → --
Summary: Allow engine selection when picking sync → Allow engine selection when setting up additional machines
Assignee: nobody → paul
We will infer settings from info/collections and surface them on additional computer setup.
Assignee: paul → mconnor
Whiteboard: [b2]
Whiteboard: [b2]
Target Milestone: 1.3 → 1.3b3
Target Milestone: 1.3b3 → 1.3b4
Attached patch v1Splinter Review
Inserts the prefs screen after the merge choice.

We'll spin off the "pre-fill these with the values inferred from the server" bit to a new bug.
Attachment #443151 - Flags: review?(edilee)
Comment on attachment 443151 [details] [diff] [review]
v1

Kinda unrelated, but onPageShow has "case 9:" instead of SETUP_SUCCESS_PAGE. Made it slightly trickier to make sure that the success page didn't have a back button for new account and existing account paths.
Attachment #443151 - Flags: review?(edilee) → review+
http://hg.mozilla.org/labs/weave/rev/dc53dc51bdc3
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Fixed the case 9 bit, should  have caught that before.

filed Bug 563459 for inferring initial values.
verified with 1.3b5
Status: RESOLVED → VERIFIED
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: