remove testevents sample plugin

RESOLVED FIXED

Status

()

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: jaas, Assigned: jaas)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 370445 [details] [diff] [review]
fix v1.0

We should remove the testevents sample plugin. It is an xpcom plugin and probably not useful to anyone. We don't want to promote the writing of xpcom plugins.
Attachment #370445 - Flags: superreview?(jst)
Comment on attachment 370445 [details] [diff] [review]
fix v1.0

- In modules/plugin/sdk/samples/Makefile.in:

+ifeq ($(OS_ARCH),WINNT)
 DIRS = common
-
-ifeq ($(OS_ARCH),WINNT)

It's not clear to me why this change is here.

r+sr=jst assuming we really want that change.
Attachment #370445 - Flags: superreview?(jst)
Attachment #370445 - Flags: superreview+
Attachment #370445 - Flags: review+
(Assignee)

Comment 2

10 years ago
There's no point to building the common base code for anything that isn't actually going to build a sample plugin right?
(Assignee)

Comment 3

10 years ago
pushed to mozilla-central without the makefile change for now

http://hg.mozilla.org/mozilla-central/rev/7348ed185ae2
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.