Closed Bug 486353 Opened 11 years ago Closed 11 years ago

remove some unused macros in style system

Categories

(Core :: CSS Parsing and Computation, defect, P5)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.2a1

People

(Reporter: dbaron, Assigned: dbaron)

Details

Attachments

(2 files)

remove constant that should have been removed with -moz-key-equivalent
832 bytes, patch
bzbarsky
: review+
bzbarsky
: superreview+
Details | Diff | Splinter Review
remove CSS_PROP_NOTIMPLEMENTED
4.89 KB, patch
bzbarsky
: review+
bzbarsky
: superreview+
Details | Diff | Splinter Review 
I came across two unused macros recently.  Patches to remove both of them coming shortly.
Remove CSS_PROP_NOTIMPLEMENTED, which was for properties that we had DOM support for without backend support for (i.e., properties in nsIDOMCSS2Properties that we did not parse).  That set was initially outline-* and counter-* when this macro was created in bug 117500, and the set hit empty when bug 3247 landed (i.e., we could have removed it then or anytime since).
Attachment #370454 - Flags: superreview?(bzbarsky)
Attachment #370454 - Flags: review?(bzbarsky)
(For the record, found the first while looking through old style system bugs and marking bug 47351 as wontfix, and the second while reading code to understand bug 469244.)
Attachment #370453 - Flags: superreview?(bzbarsky)
Attachment #370453 - Flags: superreview+
Attachment #370453 - Flags: review?(bzbarsky)
Attachment #370453 - Flags: review+
Attachment #370454 - Flags: superreview?(bzbarsky)
Attachment #370454 - Flags: superreview+
Attachment #370454 - Flags: review?(bzbarsky)
Attachment #370454 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/de0e83fb6d99
http://hg.mozilla.org/mozilla-central/rev/200c0221f643
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Priority: -- → P5
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.