486421 - Tests are broken for non-dev sites

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Developer Pages, defect, P3)

Description

[Wil Clouser [:clouserw]]

A side effect of bug 476026 I imagine but setting DEV=false locks us out of all our tests because it is using the -test database for the sessions (people are required to be logged in to view tests).

It should be using the regular database.

Comment 1

[Wil Clouser [:clouserw]]

Also appears broken on preview.amo.

Comment 2

[Jeff Balogh (:jbalogh)]

Attachment: making tests available when DEV is False

This one's pretty weird, I want to make sure I'm not the only one it works for.  We need to make sure it works on unit tests (which only change the db config once) and web tests, which change the config every time $this->get() is called.

To test:
1. Make sure you have DEV=False and that you're logged in.
2. For unit tests: /tests?case=models/user.test.php
3. For web tests: /tests?case=controllers/users_controller.test.php

Comment 3

[Wil Clouser [:clouserw]]

Comment on attachment 371759 [details] [diff] [review]
 making tests available when DEV is False

This fixes it for me.  One of your comments says the production and test schemas are different - they shouldn't be.

Comment 4

[Jeff Balogh (:jbalogh)]

They're different when you're testing new schema changes, which is valid, I think.

They're also different because the users table in remora.sql doesn't have the vanilla* mess.

Comment 5

[Jeff Balogh (:jbalogh)]

Ugh, this isn't as fixed as I thought it was: users_controller.test isn't a web test.  

views/addons/display.test.php really is a web test, and it's broken with dev=false since there's a check for `if (DEV)` in app_controller before switching to the test db.

Comment 6

[Jeff Balogh (:jbalogh)]

Pushing non-contribution bugs to 5.0.8.