new basic sample plugin for unix

RESOLVED FIXED

Status

()

Core
Plug-ins
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Josh Aas, Assigned: Josh Aas)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 370531 [details] [diff] [review]
fix v1.0

This is a new basic sample plugin for linux, it is simple, doesn't require the Mozilla build system, matches the mac sample plugin in terms of design and functionality, and is bsd-licensed.
Attachment #370531 - Flags: superreview?(jst)
Comment on attachment 370531 [details] [diff] [review]
fix v1.0

+static void drawWindow(InstanceData* instanceData, GdkDrawable* gdkWindow) {

Just a style nit, stick the opening curly brace on a line of it's own to match other code in this file (and other mozilla code in general). And I'd also stick the return type declaration on it's own line to keep the lines shorter, but I can go either way there.

r+sr=jst
Attachment #370531 - Flags: superreview?(jst)
Attachment #370531 - Flags: superreview+
Attachment #370531 - Flags: review+
(Assignee)

Comment 2

9 years ago
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/fc77a5f31b9d
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Comment 3

9 years ago
formatting changes pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/d4d0cdc09332
You need to log in before you can comment on or make changes to this bug.