Closed Bug 486539 Opened 15 years ago Closed 15 years ago

Update the hg hooks for hg 1.2

Categories

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Product:
Developer Services
Component:
Mercurial: hg.mozilla.org
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: benjamin, Unassigned)

References

Details

hg 1.2 changed/added a better hook interface for pre-transaction-commit hooks, so that the uncommitted transaction is not visible to other users. We should adopt this for hg 1.2: some hooks like the closed-tree hook may not require any changes, but I think the pushlog-recording hook will.
Which hook is that precisely?
The pushlog hook tests pass on hg 1.2.1 on my Mac, actually.

It looks like the implementation of this in hg is transparent to the hooks themselves:
http://www.selenic.com/mercurial/bts/issue1321
http://www.selenic.com/pipermail/mercurial-devel/2009-January/009838.html

Specifically, the hook's localrepo object is given access to both the existing repo and the uncommitted changes. I don't think we need to do anything here.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → WORKSFORME
Product: mozilla.org → Release Engineering
Product: Release Engineering → Developer Services
You need to log in before you can comment on or make changes to this bug.