Closed Bug 486562 Opened 12 years ago Closed 12 years ago

remove WidgetStack handleEvents code

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
fennec1.0b1

People

(Reporter: Gavin, Assigned: Gavin)

Details

Attachments

(1 file)

This code exists to allow the WidgetStack to handle its own events, but we don't use it. I think it would be a good idea to get rid of it to simplify the WidgetStack code.
Attached patch patchSplinter Review
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #370699 - Flags: review?(vladimir)
Attachment #370699 - Flags: review?(combee)
Comment on attachment 370699 [details] [diff] [review]
patch

I looked over the changes -- handleEvent is never called from any other place, and all the other removed methods and vars are only used from _handleEvent.
Attachment #370699 - Flags: review?(combee) → review+
Comment on attachment 370699 [details] [diff] [review]
patch

Hm, that code was handy for stand-alone testing, but I guess the tests can implement their own dragging code.
Attachment #370699 - Flags: review?(vladimir) → review+
https://hg.mozilla.org/mobile-browser/rev/15d2d3a9c966
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Fennec A3
You need to log in before you can comment on or make changes to this bug.