All users were logged out of Bugzilla on October 13th, 2018

When replaying a video the audio does not play

VERIFIED FIXED

Status

()

P2
normal
VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: cajbir, Assigned: cajbir)

Tracking

({verified1.9.1})

Trunk
x86
Linux
verified1.9.1
Points:
---
Bug Flags:
blocking1.9.1 +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Playing the video in the URL plays both video and audio. When the video completes playing, clicking 'play' again results in the video re-starting but no sound.

Steps to reproduce:

1) Visit URL
2) Click 'Play' button on video controls
3) wait for video to complete
4) Click 'Play' again
5) Notice the absence of sound

What Should Happen:

Sound should be heard on the second playback

What does happen:

No Sound.

The issue appeared when the media cache patch landed I think. It changed 'play' in the case of a completed video so it would seek to the beginning and continue playing. Unfortunately on the completion of the first play the audio stream is 'drained' and the audio handle is no longer usable.
(Assignee)

Updated

10 years ago
Flags: blocking1.9.1?
(Assignee)

Comment 1

10 years ago
Created attachment 370815 [details] [diff] [review]
fix

blocking1.9.1?
Assignee: nobody → chris.double
Status: NEW → ASSIGNED
Attachment #370815 - Flags: superreview?(roc)
Attachment #370815 - Flags: review?(kinetik)
Attachment #370815 - Flags: review?(kinetik) → review+
Comment on attachment 370815 [details] [diff] [review]
fix

Cool.

It'd be nice if we could assert that the stream isn't reused after Drain() is called, but it seems like it'd need a flag added to nsAudioStream and a bunch of checks all over the place, so it might not be worth the effort.
Attachment #370815 - Flags: superreview?(roc) → superreview+
(Assignee)

Updated

10 years ago
Keywords: checkin-needed
Whiteboard: [needs landing]
http://hg.mozilla.org/mozilla-central/rev/918da7a13cc2
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs landing]
Flags: blocking1.9.1? → blocking1.9.1+
Priority: -- → P2
Whiteboard: [needs 191 landing]

Comment 5

10 years ago
sound galore.

Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US;
rv:1.9.2a1pre) Gecko/20090413 Minefield/3.6a1pre
and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre)
Gecko/20090413 Shiretoko/3.5b4pre
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
You need to log in before you can comment on or make changes to this bug.