486644 - improve debug output for display lists with nsDisplayTransform

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Timothy Nikkel (:tnikkel)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.0.8) Gecko/2009032609 Firefox/3.0.8
Build Identifier: 

nsDisplayTransform has a stored list of display items but it doesn't expose it using the normal GetList method. When printing out a display list it is useful to print this stored list.

Reproducible: Always

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: patch

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 370819 [details] [diff] [review]
patch

Review requests are much less likely to get lost if they're to a specific person.  In this case, roc is the right person.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 370819 [details] [diff] [review]
patch

+#ifdef NS_DEBUG
+  virtual nsDisplayWrapList* GetStoredList() { return &mStoredList; }
+#endif

Doesn't need to be virtual. Otherwise good.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Post a new patch, and we can get this landed.

Comment 5

[Timothy Nikkel (:tnikkel)]

Attachment: patch with review comment addressed

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/94460d21365a

Thanks!!!